Update STE UserTriggerDecision and UserModification events #4955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add multiple fields in UserTriggerDecision event and UserModification event, 2. Update the latency calculation to reflect the latest definition 3. added some initial a/b testing changes for new auto-trigger UX
...are/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererAutoTriggerService.kt
Show resolved
Hide resolved
...ftware/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererCodeCoverageTrackerTest.kt
Outdated
Show resolved
Hide resolved
| // sendUserModificationTelemetryToServiceAPI(acceptedSuggestion, 1.0) | ||
| // Will remove this later when we truly don't need toolkit user modification telemetry anymore | ||
| val document = runReadAction { | ||
| FileDocumentManager.getInstance().getDocument(file) |
There was a problem hiding this comment.
we can do this later, for simplicity, we should add document as a field of AcceptedSuggestionEntry. https://github.com/aws/aws-toolkit-jetbrains/blob/main/plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/editor/CodeWhispererEditorManager.kt#L56
Will-ShaoHua
approved these changes
Oct 10, 2024
| private const val TEST_FEATURE_NAME = "testFeature" | ||
| private const val DATA_COLLECTION_FEATURE = "IDEProjectContextDataCollection" | ||
| const val CUSTOMIZATION_ARN_OVERRIDE_NAME = "customizationArnOverride" | ||
| private const val NEW_AUTO_TRIGGER_UX = "newAutoTriggerUX" |
There was a problem hiding this comment.
could make these constants sealed data object
There was a problem hiding this comment.
like
sealed interface Feature {
val id: String
sealed data object Feature1 { id: 'feat1'}
sealed data object Feature2 { id: 'feat2' }
}
nkomonen-amazon
pushed a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Oct 10, 2024
…ification events (#5766) 1. bring back UserModification SendTelemetryEvent and track acceptedCharacterCount and unmodifiedAcceptedCharacterCount. 2. combine some latency tracking to the session object JB PR reference: aws/aws-toolkit-jetbrains#4955 ## Problem ## Solution --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
rli
approved these changes
Oct 10, 2024
tverney
pushed a commit
to tverney/aws-toolkit-vscode
that referenced
this pull request
Oct 21, 2024
…ification events (aws#5766) 1. bring back UserModification SendTelemetryEvent and track acceptedCharacterCount and unmodifiedAcceptedCharacterCount. 2. combine some latency tracking to the session object JB PR reference: aws/aws-toolkit-jetbrains#4955 ## Problem ## Solution --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.